This repository was archived by the owner on Aug 26, 2025. It is now read-only.
Avoid array usage to store disappearing transitions on beachsection removal#32
Open
fjwong wants to merge 1 commit intogorhill:masterfrom
Open
Avoid array usage to store disappearing transitions on beachsection removal#32fjwong wants to merge 1 commit intogorhill:masterfrom
fjwong wants to merge 1 commit intogorhill:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a beachsection is removed, the original implementation creates an array and stores all "disappearing transitions" in it, so that the starting points of their edges can be updated.
This PR changes the removeBeachsection method so that endpoints are set when cycling through the disappearing transitions the first time, avoiding the creation of this new array, and reducing the amount of time spent on garbage collection because of this.